apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
68 stars 73 forks source link

Open menu links to external websites in a new tab #1393

Closed ihalaij1 closed 2 months ago

ihalaij1 commented 2 months ago

Description

What?

Open menu links to external websites, such as https://google.com in a new tab, instead of in the current tab.

Why?

This problem was pointed out by a teacher.

Fixes #1392

ihalaij1 commented 2 months ago

Seems to work fine - having to assign the separate is_external_menu_url_flag variable just for one if statement feels a bit clunky, but at least according to a quick google search it doesn't look like there's a better alternative :/

Yes, I tried to do it on one line first, but it didn't work...