search

apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
68 stars 73 forks source link

Double-check if we need so many modals #589

Open mtthwhggns opened 4 years ago

mtthwhggns commented 4 years ago

Every page currently includes a page_modal and a file_modal, although they're not displayed until activated.

They have some accessibility problems when they are activated (detailed in the audit, link below). This is definitely fixable, but before we put time into this, let's double-check whether they are the best way to display the content.

Feel free to share any thoughts here. @saarasat - Jaakko said you're working on something related to this.

Related: https://apluslms.github.io/accessibility-audit/patterns/fixable-a/modals/

markkuriekkinen commented 4 years ago

Jaakko already had ideas about removing the modal dialogs in the chapter/exercise pages. The submission feedback could be opened within the exercise frame instead of opening modals. Saara is working on this.

saarasat commented 4 years ago

To update what I will be working, is first and foremost removing this modal, present in questionnaires:

image

So at the moment, the other modals (especially the ones not related questionnaires) are not going to be worked by me anytime soon.

markkuriekkinen commented 3 years ago

PR https://github.com/apluslms/a-plus/pull/640 removed the chapter modal dialog from questionnaire exercises.

Randomized questionnaires still depend on the modal dialog: https://github.com/apluslms/a-plus/issues/785

ihalaij1 commented 1 year ago

There exists an aria-modal attribute that might be useful. It removes the need for aria-hidden from the modal background.