apluslms / apluslms.github.io

https://apluslms.github.io
0 stars 5 forks source link

Documentation for usage of translation string keys in the a-plus repo #7

Closed etanttila closed 3 years ago

etanttila commented 3 years ago

Description

Documentation for usage of translation string keys in the a-plus repository. Also, updated typical makemessages call, which changes due to updation to Django 3 in development of a-plus 1.10.

Why?

In the PR 838 of a-plus, translatable strings are replaced with keys in the source code. The change in protocol as well as the format of these string must be documented.

How?

By adding documentation here in the GNU gettext styleguide.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

I checked that the documentation looks good in the fork on Github and that the links work. I did not test the site works locally.

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!

PasiSa commented 3 years ago

Changes look good to me, and I will accept the PR after the commit history is cleaned up