apluslms / gitmanager

Git manager service for A+. Separated from the MOOC-Grader.
0 stars 6 forks source link

Add ability to build in publish directory, and concurrent builds #22

Closed lainets closed 2 years ago

lainets commented 2 years ago

Description

What?

Why?

To speed up the build

How?

Fixes #21

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

Checked that you can build courses concurrently and that only one build will run per course. Checked that course worked even with the bypass enabled.

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

lainets commented 2 years ago

Made this beforehand for when the testing on minus is done.

markkuriekkinen commented 2 years ago

I forgot to say this. It looks like the exclude_patterns setting in apps.meta is not taken into account in the first build after pushing changes to apps.meta. The subsequent builds do take it into account.

lainets commented 2 years ago

I forgot to say this. It looks like the exclude_patterns setting in apps.meta is not taken into account in the first build after pushing changes to apps.meta. The subsequent builds do take it into account.

This is true, and due to the fact that the setting comes from the git repo but we need that setting before the git repo is updated. We could checkout that specific file first but I figured it doesn't matter as that setting shouldnt be required for the course build anyway (the first build will never have any extra files that would be removed)