Description

In a few locations, the hardcoded /login/ url was used.

Why?

If the login url used is different from /login/ this causes issues

How?

Using the {% url %} tag in the template, and reverse_lazy in the Python code. reverse_lazy is necessary as the url conf has not yet been loaded.

"It is useful for when you need to use a URL reversal before your project’s URLConf is loaded." https://docs.djangoproject.com/en/4.1/ref/urlresolvers/#reverse-lazy

Fixes #136

Testing

Remember to add or update unit tests for new features and changes.

How to test your changes in A-plus
How to test accessibility

What type of test did you run?

[ ] Accessibility test using the WAVE extension.
[ ] Django unit tests.
[ ] Selenium tests.
[ ] Other test. (Add a description below)
[X] Manual testing.

Ensuring that the template links to the same /login url despite changes, ensuring that the reverse_lazy does not cause issues.

Did you test the changes in

[X] Chrome
[ ] Firefox
[ ] This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

[ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

[X] Did you follow our style guides?
[X] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

[ ] documents inside the doc directory.
[ ] README.md.
[ ] Aplus Manual.
[ ] Other documentation (mention below which documentation).

Is it Done?

[ ] Reviewer has finished the code review
[ ] After the review, the developer has made changes accordingly
[ ] Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

apluslms / mooc-grader