Improve generic feedback on pick-any questions

[ihalaij1]

Description

What?

Add an additional feedback note on pick-anys when partial-points option is not used and the answer is incorrect.

Why?

Students sometimes assume that zero points means “nothing is correct”; moreover, they sometimes expect to get partial credit.

Fixes #150

Testing

What type of test did you run?

• [ ] Accessibility test using the WAVE extension.
• [ ] Django unit tests.
• [ ] Selenium tests.
• [ ] Other test. (Add a description below)
• [x] Manual testing.

Tested that the new feedback note only shows in pick-any questions without partial-points option when the answer is incorrect.

Did you test the changes in

• [x] Chrome
• [ ] Firefox
• [ ] This pull request cannot be tested in the browser.

Translation

• [x] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

• [x] Did you follow our style guides?
• [ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

• [ ] documents inside the doc directory.
• [ ] README.md.
• [ ] Aplus Manual.
• [ ] Other documentation (mention below which documentation).

Is it Done?

• [ ] Reviewer has finished the code review
• [ ] After the review, the developer has made changes accordingly
• [ ] Customer/Teacher has accepted the implementation of the feature

[ihalaij1]

I noticed that the note admonition is not displayed as a blue box on the individual exercise page (the CSS class is missing there?). Is this minor problem something that needs to be fixed?

[markkuriekkinen]

I noticed that the note admonition is not displayed as a blue box on the individual exercise page (the CSS class is missing there?). Is this minor problem something that needs to be fixed?

That is because the styles for the HTML class admonition note are only defined in the default.css file in A-plus-rst-tools: https://github.com/apluslms/a-plus-rst-tools/blob/9894bb18ca9a940455a132275b5ce7366847582a/theme/aplus/static/default.css#L53-L59

The A-plus-rst-tools styles only affect chapter pages since they are rendered to HTML by the rst tools (Sphinx).

This problem can be fixed by using the existing questionnaire feedback styles instead of adding a new info admonition. I would prefer to use the existing styles anyway.

[ihalaij1]

I made changes according to the requests you made. If multiple hints are displayed, the new hint always appears last. Here's how it looks now:

[markkuriekkinen]

I changed the git commit message and force-pushed.

[markkuriekkinen]

I now noticed that the original issue requested a slightly different trigger for the new hint:

IMO, it would be a good idea to insert an additional feedback bullet on pick-anys, to be displayed whenever a student’s answer is partially correct (i.e., something was right, but not everything).

In this pull request, the hint is triggered if the submission is partially correct or completely incorrect. However, I don't think this is an important distinction. After all, it is easy to make partially correct submissions since only one checkbox needs to be in the correct state in order to make it "partially" correct. Each checkbox is either ticked or not ticked. If the student leaves one easy obviously incorrect choice unticked, that already makes it a partially correct submission.

[jsorva]

Looks good to me, thanks @ihalaij1 and @Mankro!