apluslms / mooc-jutut

Course feedback gathering and management tool. Used with A+ learning management system.
1 stars 12 forks source link

Update django-colortag to fix tag filter urls #106

Closed etanttila closed 3 months ago

etanttila commented 3 months ago

Description

What?

Previously, when filtering feedback based on student and feedback tags, the url was constructed using ordinal numbers for the tags. Change this use tag slugs. This means that the url won't change for the same query if new tags are added (which previously occured). The change was implemented my @Mikael-Lenander in the django-colortag repository.

Why?

With the previous implementation, the url changes for the same query if new tags are added. This is not ideal.

How?

Update django-colortag to new version

Fixes #91

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

Tested that adding and filtering by colortags works (also with the query url), even after new tags are added, which would be ordered in front.

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!