etanttila
commented
4 months ago @jsorva suggested that the checkbox label would be changed from "Use regex search" to "Regex search" (I suppose the Finnish translation would respectively be changed from "Käytä regex-hakua" to "Regex-haku"). I will do this minor change at some point unless opposing opinions arise, but this can sill be reviewed before that.
Description
What?
Allow user to select to use regex search for student form contents and teacher response. This is done by checking a checkbox by the field.
Add also simple validation and error styling (because the default error message appearance breaks layout):
The layout and styling should work well responsively on different sizes of screens, e.g.:
Why?
Juha Sorva wants support for regex filtering of form contents.
How?
Implement filter, field and widget that allow selecting between default search method and a regex search. Implement simple validation and error handling (also for exercise identifier, which didn't validate regex) for regex. Change form styling to use flex, so the checkbox and label can also be positioned well.
Fixes #87
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Tested that the normal text search still seems to work, as well as the new regex search. (And that searching works also when the text field is empty). Tested also that there is a error message if the regex search is used but the search string isn't valid regex.
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Added some documentation strings withing the code. Perhaps Aplus manual should be updated also towards the end of the summer to provide info about new changes (e.g. this filtering, importing feedback tags, and other possible changes).
Is it Done?
Clean up your git commit history before submitting the pull request!