Render colortag include-exclude buttons via widget rather than js-jquery-toggle to improve performance.
Improve visuals of include-exclude buttons and padding of colortags.
Also refactor renaming of subwidgets to be more efficient and clearer.
Render AND/OR as segmented button instead of two-state button.
Add informative helptext in popover.
Also add a missing translation which was accidentally removed in a previous PR.
Why?
To improve performance, usability, etc.
How?
Add a boolean field "pinned" to the feedback tag model, which indicates if a tag should be displayed at the beginning of the list.
Requires PR#17 of django-colortag, which provides rendering and styling of the tags. Update adds a pin icon to the end of pinned tags.
Updating django-colortag include-exclude implementations.
Requires PR#18 of django-colotag and making a new release (2.5.0) of django-colortag.
Fixes #66
Should (at least help) fix #15
Testing
Remember to add or update unit tests for new features and changes.
I tested feedback tag and student tag filter (and pinning tags) with django-colortag as a submodule in mooc-jutut.
These changes should probably be also quickly tested after django-colortag is updated and a new release is made.
Did you test the changes in
[ ] Chrome
[x] Firefox
[ ] This pull request cannot be tested in the browser.
Think of what is affected by these changes and could become broken
Description
What?
Add option to pin frequently used feedback tags.
Render colortag include-exclude buttons via widget rather than js-jquery-toggle to improve performance. Improve visuals of include-exclude buttons and padding of colortags. Also refactor renaming of subwidgets to be more efficient and clearer. Render AND/OR as segmented button instead of two-state button. Add informative helptext in popover.
Also add a missing translation which was accidentally removed in a previous PR.
Why?
To improve performance, usability, etc.
How?
Add a boolean field "pinned" to the feedback tag model, which indicates if a tag should be displayed at the beginning of the list. Requires PR#17 of django-colortag, which provides rendering and styling of the tags. Update adds a pin icon to the end of pinned tags.
Updating django-colortag include-exclude implementations. Requires PR#18 of django-colotag and making a new release (2.5.0) of django-colortag.
Fixes #66 Should (at least help) fix #15
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
I tested feedback tag and student tag filter (and pinning tags) with django-colortag as a submodule in mooc-jutut. These changes should probably be also quickly tested after django-colortag is updated and a new release is made.
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
I will also update Aplus manual in the near future.
Is it Done?
Clean up your git commit history before submitting the pull request!