apluslms / mooc-jutut

Course feedback gathering and management tool. Used with A+ learning management system.
1 stars 12 forks source link

Weird URL in link button #117

Closed jsorva closed 2 months ago

jsorva commented 2 months ago

On pages such as this one https://jutut.cs.aalto.fi/manage/60/unread/ there’s a Filter/Suodatin button that sees frequent use. I use it constantly to find messages that have a particular tag (among other things).

At some point, it has stopped working properly. It no longer takes me to https://jutut.cs.aalto.fi/manage/60/feedbacks/ as expected, but instead to https://jutut.cs.aalto.fi/manage/60/feedbacks/?contains_text=on

Which is strange. This has a significant carry-on effect: if I now search for a message tag, I don’t actually get all the messages with that tag but a subset of them — the messages have to contain the substring "on".

jsorva commented 2 months ago

After further investigation, I’ve found out that there is no actual bug in functionality here — just a misleading URL.

Unlike it sounded like, the contains_text parameter does not check whether the messages contain a particular substring. (That is done by the oddly-named parameter student_text_text instead.) What the contains_text parameter does do is check whether there is any text at all present in the message. Which is fine, although the URL could be better. So I’m closing this issue.