search

apluslms / mooc-jutut

Course feedback gathering and management tool. Used with A+ learning management system.
1 stars 12 forks source link

UI texts can be weird when responding to a student #96

Open jsorva opened 1 year ago

jsorva commented 1 year ago

I just tried to respond to a student but got this strange thing (which I’ve never seen before despite having responded to possibly 10000+ student messages before):

image

Then I tried clicking on that weirdly phrased link but got this:

image

This maybe has something to do with my session expiring. (Although I just succesfully worked in Jutut just a few moments earlier. And now everything works OK for me without my having actively logged in anywhere.) But whatever the underlying reason, this does not seem like the intended behavior.

etanttila commented 6 months ago

With a quick git grep, that seems to stem from feedback.js, so as you indicated it had to do with not being authenticated (so indeed the session expiring).

  else if (xhr.status == 403) {
    // no authentication
    add_status_tag(panel, "Not authenticated!", "danger");
    alert("You are not authenticated. Do that in another tab, then open this reponse in another tab and copy input. Then you can refesh this page.");
    panel.find('.response-label-container').html('<a href="'+url+'">Link to this responses update page. Open in new tab!</a>');

Do you remember, was there some kind of visible alert about the lack of authentication (as there apparently should have been)? This bug may be somewhat difficult to duplicate. But indeed that does not seem like intended behavior, especially if the link didn't work. (Note: from the code it seems like the url is the url where the POST request is spent; the link test is also misleading, it wouldn't open it in a new tab.) So indeed the link target but also the link text should probably be clarified, and probably reconsidered what is actually desired behavior (should there be a clearer indication of lack of authentification, etc.

jsorva commented 6 months ago

I’m afraid I can’t remember any details beyond what’s written in the issue. Sorry!