search

apmoore1 / target-extraction

Target based extraction
https://apmoore1.github.io/target-extraction/
Apache License 2.0
4 stars 1 forks source link

code coverage for models #26

Closed apmoore1 closed 4 years ago

apmoore1 commented 4 years ago

The allennlp models are having low code coverage. This is because allennlp has changed the way it creates its tests it now does not subclass unittest class but rather uses unittest mock. Thus none of the tests are now running due to the requirement the class name has to have the word Test at the start of the class. This all needs updating along with using setup_method instead of setUp.

apmoore1 commented 4 years ago

This is now closed as the coverage is back up to normal levels and travis works