search

apmorton / pyhidapi

hidapi bindings in ctypes
MIT License
112 stars 42 forks source link

Add improvements on import errors and update library version #14

Closed 3demax closed 5 years ago

3demax commented 7 years ago

There are 2 PRs that can easily improve library usability: #12 and #13 Also, the package on pypi doesn't contain fixes from master.

@apmorton Please take a look.

apmorton commented 7 years ago

Hello, Thanks for your interest in this library, and sorry for the lack of maintenance on my end with regards to PRs and updates to pypi.

In any case, which PR would you like me to merge? #12 would conflict with the changes you make in #13

IMO, #13 is not strictly an improvement if the proper ImportError is thrown, which was fixed by @NZSmartie some time ago, but as you mentioned never got published to pypi.

Unless you want to send in another PR I will merge #12, close #13, and bump the version on pypi.

I will wait till I hear back from you in any case.

Thanks, Austin

3demax commented 7 years ago

Thank you for quick response! I have updated #13 so that it combines both. Hope you can merge this now.

3demax commented 7 years ago

@apmorton Is it better now?