search

apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

Move initializer for ActsAsGmappable to Rails::Railtie #137

Closed PikachuEXE closed 12 years ago

PikachuEXE commented 12 years ago

I do this to make sure when RailsAdmin run audit_with, the method "acts_as_gmappable" is defined / ActsAsGmappable is included already

apneadiving commented 12 years ago

It seems there are many different things in your commits.

The main point is you remove ActiveSupport.onload and include directly ActsAsGmappable in ActiveRecord.

This is not acceptable as it will break for Mongoid (or other ORM) users.

Do you have some details about your issue?

PikachuEXE commented 12 years ago

https://github.com/sferik/rails_admin/issues/921 I have issue when using audit_with on RailsAdmin

Remove ActiveSupport.onload? I know I did that in some commit but that was just for testing The Diff only shows that I moved the ORM initializer from Engine to Railtie and the ActiveSupport.onload still exists If you want a cleaner commit I will do it

apneadiving commented 12 years ago

I'd like to.

Indeed, I'm on iphone and it's a pain to understand the final Result. Did you simply changed from engine to Railtie?

PikachuEXE commented 12 years ago

I only moved initializer "include acts_as_gmappable within ORM" from Engine to Railte ActiveSupport.onload is not touched I am going to make another cleaner pull request now