apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

bug with rails 3.2: analyse assets / pipeline activés #199

Closed deneuxa closed 12 years ago

deneuxa commented 12 years ago

Rails.configuration.methods.include?('assets') => true

Rails.configuration.methods.include?(:assets) => false

=> so the method gmaps4rails_pipeline_enabled always give false ....

apneadiving commented 12 years ago

Thanks,

fixed but you'll have to wait for the new release: https://github.com/apneadiving/Google-Maps-for-Rails/blob/new_gen/lib/gmaps4rails/view_helper.rb#L63

apneadiving commented 12 years ago

Really weird though, I've exactly the opposite of your results:

ruby-1.9.2-p290 :001 > Rails.configuration.methods.include?('assets') 
 => false 
ruby-1.9.2-p290 :002 > Rails.configuration.methods.include?(:assets)
 => true 
deneuxa commented 12 years ago

I'm ruby1.8.7 and rails3.2.2:

Loading development environment (Rails 3.2.2)

Rails.configuration.methods.include?('assets') => true Rails.configuration.methods.include?(:assets) => false

Crazy !

apneadiving commented 12 years ago

:)

would you mind trying:

Rails.configuration.respond_to?('assets') && Rails.configuration.assets.enabled
deneuxa commented 12 years ago

Rails.configuration.respond_to?('assets') && Rails.configuration.assets.enabled => true

Rails.configuration.respond_to?(:assets) && Rails.configuration.assets.enabled => true

2012/4/30 Benjamin Roth < reply@reply.github.com

:)

would you mind trying:

Rails.configuration.respond_to?('assets') && Rails.configuration.assets.enabled


Reply to this email directly or view it on GitHub:

https://github.com/apneadiving/Google-Maps-for-Rails/issues/199#issuecomment-5428451

apneadiving commented 12 years ago

ok will keep that then. I'm gonna release a rc version in a few minutes, I've refactored much code. So I'll make some tests on it.

apneadiving commented 12 years ago

Just released 1.5.0.pre

Would you mind testing it?

deneuxa commented 12 years ago

humm.. my map doesnt render anymore.. I'm doing this: (works with 1.4.8)

= gmaps("markers" => {"data" => @json}, "polylines" => { "data" => @polylines || false }, :map_options => {:center_longitude => @user.longitude, :center_latitude => @user.latitude, :auto_adjust => (!@me.nil?), :zoom =>12, :draggable=>true, :raw => "{ scrollwheel: true, streetViewControl: false, zoomControl: true, mapTypeControl: false}" })

2012/5/1 Benjamin Roth < reply@reply.github.com

Just released 1.5.0.pre

Would you mind testing it?


Reply to this email directly or view it on GitHub:

https://github.com/apneadiving/Google-Maps-for-Rails/issues/199#issuecomment-5429230

deneuxa commented 12 years ago

my mistake: I forgot to run rails generate gmaps4rails:install Seems to work fine I'll put it on prod this afternoon

2012/5/1 alexis Deneux deneuxa@gmail.com

humm.. my map doesnt render anymore.. I'm doing this: (works with 1.4.8)

= gmaps("markers" => {"data" => @json}, "polylines" => { "data" => @polylines || false }, :map_options => {:center_longitude => @user.longitude, :center_latitude => @user.latitude, :auto_adjust => (!@me.nil?), :zoom =>12, :draggable=>true, :raw => "{ scrollwheel: true, streetViewControl: false, zoomControl: true, mapTypeControl: false}" })

2012/5/1 Benjamin Roth < reply@reply.github.com

Just released 1.5.0.pre

Would you mind testing it?


Reply to this email directly or view it on GitHub:

https://github.com/apneadiving/Google-Maps-for-Rails/issues/199#issuecomment-5429230

apneadiving commented 12 years ago

Ok good news :)

Just finished 1.5.0.pre2 which deprecates Gmaps.map.map in favor of Gmpas.map.serviceObject

Gmaps.map.map still exists but will be removed in later version