search

apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

necessity to install new files after each upgrade #204

Closed levraipixel closed 12 years ago

levraipixel commented 12 years ago

Hi Benjamin,

Could you explain why you don't provide assets in vendor/assets like other gems ? I find it pretty anoying to have to "rails generate gmaps4rails:install" everytime you update this gem...

Yann

PS: anyway, still a great gem ;)

apneadiving commented 12 years ago

I had too many questions about so called bugs due to people ignoring rules in Rails 3.0.x and Rails > 3.1.

So I decided to have a unique way for the setup: now people see files...

Yes it's a little bit more tedious for you but it's a relief for me.

Sent from my iPhone

On 5 mai 2012, at 16:17, Yann Hourdelreply@reply.github.com wrote:

Hi Benjamin,

Could you explain why you don't provide assets in vendor/assets like other gems ? I find it pretty anoying to have to "rails generate gmaps4rails:install" everytime you update this gem...

Yann

PS: anyway, still a great gem ;)

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/issues/204

levraipixel commented 12 years ago

ok, I understand. Thx for the answer =)

apneadiving commented 12 years ago

:)

Another point is this way people see the js files and the no-magic behind them.

Sent from my iPhone

On 5 mai 2012, at 16:47, Yann Hourdelreply@reply.github.com wrote:

ok, I understand. Thx for the answer =)

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/issues/204#issuecomment-5527611

levraipixel commented 12 years ago

that's not very Rails, but I see what you mean. Maybe you could keep the files in vendor/assets but don't documente this usage and advise everyone to use the install method like right now.

apneadiving commented 12 years ago

I won't do that but could add a section in the readme to tell you how to do.

Sent from my iPhone

On 5 mai 2012, at 17:03, Yann Hourdelreply@reply.github.com wrote:

that's not very Rails, but I see what you mean. Maybe you could keep the files in vendor/assets but don't documente this usage and advise everyone to use the install method like right now.

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/issues/204#issuecomment-5527721

apneadiving commented 12 years ago

Just thought twice: I didn't try yet but I guess you've nothing to do to het the files from the gem.

Actually, it's a Rails Engine and the coffee files are in app/assets/javascripts/gmaps4rails which should be directly available in your Rails >= 3.1 app.

Just require it!

Sent from my iPhone

On 5 mai 2012, at 17:03, Yann Hourdelreply@reply.github.com wrote:

that's not very Rails, but I see what you mean. Maybe you could keep the files in vendor/assets but don't documente this usage and advise everyone to use the install method like right now.

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/issues/204#issuecomment-5527721

levraipixel commented 12 years ago

it's ok for the JS, but not for the CSS

apneadiving commented 12 years ago

Yep, but css is supposed to be customized!

Sent from my iPhone

On 5 mai 2012, at 19:37, Yann Hourdelreply@reply.github.com wrote:

it's ok for the JS, but not for the CSS

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/issues/204#issuecomment-5528939

levraipixel commented 12 years ago

seems fair, so I just keep the CSS in my folders and require the JS directly from your gem ;)

dgm commented 12 years ago

If css and javascript are in vendor assets, you can always override css in your own application.css ... It's the way other things like bootstrap, compass, formtastic, etc do.

molfar commented 11 years ago

First time using this gem, rails generate gmaps4rails:install just makes me crazy and confusing. Why not using assets pipeline like all other gems?

apneadiving commented 11 years ago

Hello, heck no… I should not be more polite than you are

most people need to overwrite the js and/or css, it just makes it easier.

Of course, asset pipeline could/should be used. I'm waiting for your pull request.

On Feb 9, 2013, at 7:54 PM, molfar notifications@github.com wrote:

First time using this gem, rails generate gmaps4rails:install just makes me crazy and confusing. Why not using assets pipeline like all other gems?

— Reply to this email directly or view it on GitHub..