search

apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

Added support for storing, retrieving lat,lng coordinates from an Array in the model - useful for Mongo DB and similar #220

Closed kristianmandrup closed 12 years ago

kristianmandrup commented 12 years ago

There needs to be test coverage of this feature of course. But I'm using this feature with success myself ;)

apneadiving commented 12 years ago

Just overlooked it right now but will dig later

kristianmandrup commented 12 years ago

Ah yeah, I will fix that now! Thanks :)

nithinbekal commented 12 years ago

This would be very useful, as I'm using Mongoid myself on one of my projects. Thanks for this feature, @kristianmandrup.:)

@apneadiving Any chance 1.5.3 is being released soon? :) And would this make it to the release?

apneadiving commented 12 years ago

Would be good but requires some specs, simply.

Sent from my iPhone

On 23 juin 2012, at 12:48, Nithin Bekalreply@reply.github.com wrote:

This would be very useful, as I'm using Mongoid myself on one of my projects. Thanks for this feature, @kristianmandrup.:)

@apneadiving Any chance 1.5.3 is being released soon? :) And would this make it to the release?

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/pull/220#issuecomment-6524207

kristianmandrup commented 12 years ago

I will add some.specs ASAP ;)

apneadiving commented 12 years ago

Great!

I've refactored almost all the gem these days.

I need your specs to be sure I don't break anything.

Sent from my iPhone

On 23 juin 2012, at 13:21, Kristian Mandrupreply@reply.github.com wrote:

I will add some.specs ASAP ;)

Reply to this email directly or view it on GitHub: https://github.com/apneadiving/Google-Maps-for-Rails/pull/220#issuecomment-6524347

kristianmandrup commented 12 years ago

I merged your latest changed and did some a little refactoring in the new ModelHandler using Extract Method pattern to "pretty it up". I've also added a Place model to the dummy app which is a simple Ruby class not using ActiveRecord. I then added a place_spec which will use the place model instead of user. If you can get this to work, it should be easy to add mongoid as a dependency for testing and then setup the dummy app to also use mongoid/mongo as the data storage engine.

apneadiving commented 12 years ago

Sounds good, reopen a pull request when you're done!