search

apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

Yandex.Maps #336

Closed xsve closed 11 years ago

xsve commented 11 years ago

I've implemented Yandex.Maps API support in gmaps4rails. You can find the current state of API implementation here.

apneadiving commented 11 years ago

sorry for the delay. The PR seems not to be directly mergeable.

Could you please fix this, I'll accept it once done.

Thanks

xsve commented 11 years ago

I pulled in changes from upstream, the merge is a fast-forward now.

apneadiving commented 11 years ago

Thanks!

xsve commented 11 years ago

Thank you for this awesome gem! Adding another API support was as easy as a pie!

On Thu, Aug 29, 2013 at 10:05 AM, Benjamin Roth notifications@github.comwrote:

Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/apneadiving/Google-Maps-for-Rails/pull/336#issuecomment-23470751 .

Regards, Sergei Velhas

apneadiving commented 10 years ago

I'm very sorry because I dropped all map providers in my new v2.

I've changed most of the code too.

Actually I feel like, as oauth does, other map providers should be other gems, much easier to have split responsibilities.

You'd see that in the new js, it's even easier to adapt stuff, maybe you'll find the inspiration to do the yandex work again...

Hope this doesnt disappoint you but I did this for the sustainability of the gem.

Ben