apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

Issue with Foundation versions after 4.2.1 #363

Closed JamesChevalier closed 11 years ago

JamesChevalier commented 11 years ago

With Foundation 4.2.1, gmaps4rails will work fine. With versions of Foundation after that, gmaps4rails will not load.

I haven't noticed any error messages - in the Rails console or in Chrome's Developer Tools. The map simply doesn't load.

I've set up two Rails apps to show this issue:

I'm submitting this same Issue to the Foundation project (here), since I'm not sure what's causing the issue. I'm happy to do any needed legwork to help get this issue resolved - I just don't know what the next steps are.

JamesChevalier commented 11 years ago

A conversation on Twitter is suggesting that the problem is with placeholder.js in Foundation.

JamesChevalier commented 11 years ago

The problem is specifically with these three lines in Foundation's placeholder.js.

I notice that it was just radically updated a few minutes ago (git history). I haven't had a chance to test this change, so I don't know if it resolves the issue or not.

JamesChevalier commented 11 years ago

I've been able to confirm that commit 9315379769170017d1231fd2a5b83f9869d4f9ce fixes this issue.

I've set up another example Rails app to show that sourcing zurb-foundation from github allows the gmaps4rails map to display.

I'll close this issue, as it was a problem in Foundation.

apneadiving commented 11 years ago

Thank you James!

Sent from my iPhone

On 24 juil. 2013, at 19:06, James Chevalier notifications@github.com wrote:

I've been able to confirm that commit 9315379769170017d1231fd2a5b83f9869d4f9ce fixes this issue.

I've set up another example Rails app to show that sourcing zurb-foundation from github allows the gmaps4rails map to display.

I'll close this issue, as it was a problem in Foundation.

— Reply to this email directly or view it on GitHub.