Allow scaled in options

apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps

https://apneadiving.github.io/

MIT License

2.26k stars 382 forks source link

Allow scaled in options #386

Closed jonathanng closed 10 years ago

apneadiving commented 10 years ago

What happens if info are not available?

I dont like the naming, please use underscore like I do elsewhere

apneadiving commented 10 years ago

I may be a pain, but tell me, either:

you isolate size creation in a separate method (which name something like _retina_size)
or I do this myself outside of the PR

Thanks :)

jonathanng commented 10 years ago

I think using rick markers is the easiest way to support retina images. Rich markers has the added benefit in that you can use sprites. Much cleaner this way.

So closing this. I updated the wiki here to make it more clear how to implement rick markers:

https://github.com/apneadiving/Google-Maps-for-Rails/wiki/Change-handler-behavior/d55ecf34d97b617a44b5da09e9975b5956e8801f

apneadiving commented 10 years ago

Ok thanks, interesting feedback!