apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

Problems after upgrading to 1.0 #74

Closed iRonin closed 13 years ago

iRonin commented 13 years ago

First of all, thank you for fixing all the bugs!

I have a question though: what was the reason of changing id="map_container" to class="map_container"? Due to this change parts of my code and styles stopped working. I can see you also changed id of the inner container, now 'map'.

Are such changes listed anywhere? It would be helpful to have them for gem users to upgrade.

apneadiving commented 13 years ago

This definitely needed some info.

Here you go: https://github.com/apneadiving/Google-Maps-for-Rails/wiki/From-0.x.x-to-1.x.x

iRonin commented 13 years ago

Thank you!

apneadiving commented 13 years ago

Thanks for your feedback :)

iRonin commented 13 years ago

I'm working heavily with your gem so you can expect a lot of feedback :)