search

apneadiving / Google-Maps-for-Rails

Enables easy Google map + overlays creation in Ruby apps
https://apneadiving.github.io/
MIT License
2.26k stars 382 forks source link

Info windows do not close automatically #78

Closed iRonin closed 13 years ago

iRonin commented 13 years ago

If I read your code right openInfoWindow should close currently opened info windows - however it does not. Somehow this.visibleInfoWindow is null inside of the aforementioned function.

apneadiving commented 13 years ago

good catch, just solved in my latest commit, will release once you got 42 other bugs ;)

apneadiving commented 13 years ago

Yep, I haven't released yet. Did you get the version from github.

iRonin commented 13 years ago

I've just forked it and noticed the fix.

apneadiving commented 13 years ago

Ok. I'm rewriting the whole js in coffeescript.

This would need some proof reading.

Tell me if you're in.

iRonin commented 13 years ago

Coffeescript? All in!

apneadiving commented 13 years ago

Great news, I'm almost done and ready to push

apneadiving commented 13 years ago

Just released 1.1.0 with coffeescript based js. See: https://github.com/apneadiving/Google-Maps-for-Rails/tree/master/app/assets/javascripts/gmaps4rails