createServiceMarkersFromMarkers error when markers=[]

[iRonin]

Gmaps4Rails.createServiceMarkersFromMarkers throws an error when markers=[]. Simple if check should solve the issue, eg:

create_markers : ->
    @createServiceMarkersFromMarkers() if @markers.length > 0
    @clusterize()

[apneadiving]

Really? The loop is failing???

[iRonin]

Uncaught TypeError: Cannot read property 'lat' of undefined
Gmaps4Rails.Gmaps4Rails.createServiceMarkersFromMarkers

[apneadiving]

I'm disappointed the 'for' loop from coffeescript doesn't handle this. I'll fix that but it could be necessary in many places...

[iRonin]

Perhaps it's only the case for ranges? I would also think for loop should handle this.

[apneadiving]

ok, got it, my code was not that clean, will replace with:

for marker, index in markers

That will fix. Anything else to add to the new version? :)

[iRonin]

Not at the moment ;)