search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
234 stars 112 forks source link

Support npipe:// in DOCKER_HOST #106

Closed bwateratmsft closed 5 years ago

bwateratmsft commented 5 years ago

In Windows, DOCKER_HOST can contain things like npipe:////./pipe/docker_engine or npipe:////./pipe/docker_wsl.

Currently it isn't possible to use DOCKER_HOST = npipe:////./pipe/docker_wsl to use the WSL2 Docker engine; rather, you must pass in socketPath to dockerode. If you try using the above for DOCKER_HOST you'll get an error.

bwateratmsft commented 5 years ago

Related to https://github.com/apocas/dockerode/issues/526, https://github.com/microsoft/vscode-docker/issues/1199, https://github.com/microsoft/vscode-remote-release/issues/1089

apocas commented 5 years ago

👍 Will publish it tonight.

bwateratmsft commented 5 years ago

👍 Will publish it tonight.

@apocas Thanks! How soon would this new version make it into dockerode?

apocas commented 5 years ago

Just published docker-modem v2.0.2. It's available now, just update dockerode dependencies via npm :)

bwateratmsft commented 5 years ago

Awesome! I'll try it out!