Cache SSH auth agent

[bwateratmsft]

@apocas I made a silly mistake in #108. The vscode-docker extension has application settings that control DOCKER_HOST (which allows workspace-specific settings), the way we do it is to set DOCKER_HOST, create the Dockerode object, and then revert back to the prior environment variables.

Because of this implementation, we were also reverting back the SSH_AUTH_SOCK value, and when subsequent requests came in, the variable was no longer set at this line, causing failed requests: https://github.com/apocas/docker-modem/blob/f3836543f808a015e073a1cb355698b9248425b0/lib/modem.js#L208

No rush on getting this deployed, I can work around it for now, but since everything else is cached from reading DOCKER_HOST at the beginning it makes sense to do the same with SSH_AUTH_SOCK.

[apocas]

Yeah, I completely missed that too. 👍

[bwateratmsft]

@apocas We're getting close to releasing our next extension version of vscode-docker, probably soon after VSCode 1.40 is out. Can you release the next version of docker-modem?

Thanks in advance, I really appreciate it!

[apocas]

Going to publish it today.

On Fri, 1 Nov 2019 at 14:33, Brandon Waterloo [MSFT] < notifications@github.com> wrote:

@apocas https://github.com/apocas We're getting close to releasing our next extension version of vscode-docker, probably soon after VSCode 1.40 is out. Can you release the next version of docker-modem?

Thanks in advance, I really appreciate it!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/apocas/docker-modem/pull/109?email_source=notifications&email_token=AAER3JLFJS7XTJDIJLCSZXDQRQ44VA5CNFSM4JB6YQGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3C4AI#issuecomment-548810241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAER3JJFAFGHNHUIUOSPN4DQRQ44VANCNFSM4JB6YQGA .

-- Pedro Dias

[apocas]

Published in v2.0.4