search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
234 stars 112 forks source link

Option registryConfig should also be removed from the query string #115

Closed gautaz closed 7 months ago

gautaz commented 4 years ago

Hello,

Looking at: https://github.com/apocas/docker-modem/blob/419cd89ff7ea04289c132503bf4d429da13adbd4/lib/modem.js#L104-L107

As the header X-Registry-Config is bound to contain the user docker configuration which holds all her credentials to the different repositories she is actually logged in, these information are also sensible and should not appear in the query string. So I think opts.registryConfig should also be removed from the options in order to not show up in the query string.

@apocas I can provide a PR if necessary but you might want to look into it first.

gautaz commented 7 months ago

Spring cleaning time! There is no need to keep this issue anymore, feel free to reopen a new one if needed.