search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
235 stars 112 forks source link

8be3b43 clutters output #116

Closed natlibfi-arlehiko closed 4 years ago

natlibfi-arlehiko commented 4 years ago

Commit 8be3b43291aaa5660bdafcea4396c708585056c6 seems to have added the console.log to the code: https://github.com/apocas/docker-modem/blob/8be3b43291aaa5660bdafcea4396c708585056c6/lib/modem.js#L404 Is this on purpose? I don't think it's good practise for libraries/modules to do logging automatically. If on purpose, please consider using debug instead.

apocas commented 4 years ago

Fixed and published. v2.1.1 It was left behind :/