search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
234 stars 112 forks source link

Allow arbitrary sshOptions to be passed to ssh2 #120

Closed steverice closed 4 years ago

steverice commented 4 years ago

This allows for an arbitrary sshOptions to be passed in Modem options and be used when passed to the ssh constructor to get an agent from the ssh2 library.

This is a breaking change as some previous options are no longer supported.

Effectively reverts b565f5595d255e6e8149abe82dfacc2d9cff7c07, d2f92b22cf284d537a57cc255ba11b4c4c5d7b61, and part of 05f4319aa070c74b967b3ad2342e4d2243980cbf.

steverice commented 4 years ago

As discussed in https://github.com/apocas/docker-modem/pull/119#issuecomment-617983586, this is a breaking change that will require a major version bump.

HorusGoul commented 4 years ago

Can't we keep and deprecate the old config alongside the new sshOptions config to avoid a major version bump right now? Also is there anything blocking this PR? I could probably help if it's related to development. @apocas @steverice

Thanks!

iammathew commented 4 years ago

Hey, Is there anything here to do to help move this PR along? Would be willing to help out :)

apocas commented 4 years ago

Tackling this tonight.

apocas commented 4 years ago

Can't we keep and deprecate the old config alongside the new sshOptions config to avoid a major version bump right now? Also is there anything blocking this PR? I could probably help if it's related to development. @apocas @steverice

Thanks!

I don't see why we need to do a major bump with this. Retro-compatibility is maintained.