search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
234 stars 112 forks source link

Handle build data input stream errors correctly #127

Closed skadisch closed 3 years ago

skadisch commented 4 years ago

Node's readable.pipe() does not forward errors of input streams to the writable stream. This causes the build request to just hang. stream.pipeline() available in Node >= 10.0 would solve this problem, but it seems more reasonable to just call req.destroy(error) on input stream errors for backwards compatibility.

apocas commented 4 years ago

Interesting.