Set default `hijack` option to true

apocas / docker-modem

Docker Remote API network stack driver.

Apache License 2.0

234 stars 112 forks source link

Set default `hijack` option to true #148

Open phaseOne opened 2 years ago

phaseOne commented 2 years ago

I'm on Docker Desktop for ARM Mac 4.11.1 (84025) and I'm experiencing an issue with dockerode, where writing to stdin never reaches the process in my container.

Based on moby/moby#43799, it seems a change in Docker Desktop 4.10.0 requires that the Connection and Upgrade headers be sent for stream multiplexing to work, since Docker Desktop proxies the docker socket.

apocas commented 1 year ago

I'm not sure if changing this default would be a good idea.

There's a lot of use cases beside Docker Desktop, I would love more opinions on this one.