search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
234 stars 112 forks source link

Update ssh.js #160

Closed leonitousconforti closed 1 year ago

leonitousconforti commented 1 year ago

pr #154 definitely broke ssh functionality for me. Not sure why the return agent statement was moved up into agent.createConnection scope, but by doing so it results in any call to the ssh module to return undefined instead of an ssh agent. Which makes sense as this function never returns anything anymore, instead createConnection function returns the agent but that doesn't make sense based on how it is used.

apocas commented 1 year ago

Yup good catch... We definitely need to improve SSH tests in dockerode.