search

apocas / docker-modem

Docker Remote API network stack driver.
Apache License 2.0
235 stars 112 forks source link

Fix `t` query parameter for `build` command #84

Closed caseywebdev closed 7 years ago

caseywebdev commented 7 years ago

As you can see at https://docs.docker.com/engine/api/v1.29/#operation/ImageBuild, the build command is the only operation that supports multiple t=foo&t=bar parameters instead of everywhere else where it's a JSON array other=["foo","bar"]. This minor change allows multiple tags to be specified through the API when building and saves me from having to create a tmp tag that I have to retag with the actual tags I want later.

caseywebdev commented 7 years ago

@apocas thoughts on this?

apocas commented 7 years ago

👍 The lack of standardization in Docker's API, drives me nuts.

Sorry, completely missed this PR.

apocas commented 7 years ago

Will ping when published. Probably later tonight.

caseywebdev commented 7 years ago

Thanks! You've saved me the extra tag calls in my build process 😉

caseywebdev commented 7 years ago

Hey @apocas would you mind publishing this?

apocas commented 7 years ago

Published v1.0.1

caseywebdev commented 7 years ago

🎆 Thanks