Stream data directly from file system instead of loading it in memory

[juanjoDiaz]

Closes #79

Blocking node event loop and loading the whole file in memory has a pretty bad impact on apps. Especially for large containers.

This is a very minimal fix that stream the file directly to docker. The support was already there but the way of reading the file was wrong.

Tested to be even in resource-constrained systems.

[apocas]

:+1: Will ping when published.

[juanjoDiaz]

Thanks!!

I'm not sure how dockerode dependencies are set up but this change should also be reflected here.

[juanjoDiaz]

Hi @apocas,

It's been a while! Any chance to get this release soon?

It has really become a blocker for me. So either we can get this release or I'll need to fork this project and dockerode which I really don't want to :/

[apocas]

Will publish a new version later tonight :)

On Sun, 16 Sep 2018 at 14:41, Juanjo Diaz notifications@github.com wrote:

Hi @apocas https://github.com/apocas,

It's been a while! Any chance to get this release soon?

It has really become a blocker for me. So either we can get this release or I'll need to fork this project and dockerode which I really don't want to :/

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/apocas/docker-modem/pull/92#issuecomment-421767285, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkdpTtUMko1UsxyOTdUO8Ug6yRvgONwks5ublT2gaJpZM4URbvH .

-- Pedro Dias

[apocas]

Published in v1.0.7 :)

[juanjoDiaz]

Thanks!! Please don't forget to publish dockerode as well with the updated dependency :)