apocas / dockerode

Docker + Node = Dockerode (Node.js module for Docker's Remote API)
Apache License 2.0
4.35k stars 460 forks source link

Plugin configure wrong response code #779

Open ibaraki-douji opened 1 month ago

ibaraki-douji commented 1 month ago

Looking at the API docs we have a response code of 204 (https://docs.docker.com/reference/api/engine/v1.46/#tag/Plugin/operation/PluginSet) but looking at the code i see the valid response code is 200 https://github.com/apocas/dockerode/blob/49bd8c4c231efe9bb432b28d51dbae3e50ddd010/lib/plugin.js#L301 which cause dockerode to throw an error (http 204 unexpected)