Closed wisechengyi closed 7 years ago
Hi Yi,
I have a couple things I would like you to address before I pull this into the main repository:
I think that's it. Other than that, it looks good!
Addressed all comments. Should be good now. Thanks, Yi
@apockill btw are you working in shenzhen now?
ping
Hi Yi, sorry about the delay, it's been a busy few days. I'm actually studying in Arizona right now.
Anyways, looks good! I'll pull it in.
@apockill when you merge, you probably want to use the squash
option on github. Otherwise a lot my meaningless commit messages will show up on master :P
PR for #14
Other changes:
refreshDevicesIcon
on camera change events.