add the ability to import new tracker from torrents already downloading

[GoogleCodeExporter]

If you Add a torrent which is already downloading(hash is the same)
only add the new trackers from that torrent to the torrent all ready downloading

Original issue reported on code.google.com by arn...@hadasbros.com on 23 May 2011 at 8:23

[GoogleCodeExporter]

Hi I've also been looking at this:
Have already modified the code to implement this.
I'll attach patch files as soon as i'm finished testing...

Original comment by rayfitzh...@gmail.com on 29 Jun 2011 at 2:03

[GoogleCodeExporter]

Hi folks,

Here's the patch as promised.

It's implemented by way of 2 new commands.
DuplicateTorrentCommand is executed when the server responds with a duplicate 
torrent error. This command then creates an addTracker request.
When the addTracker request completes it calls 
TrackerAddedCommand which updates the tray icon to display a baloon popup with 
the added trackers listed.

Best regards,
Ray

Original comment by rayfitzh...@gmail.com on 30 Jun 2011 at 8:43

Attachments:

• AddTrackersWhenTorrentAlreadyExists.patch

[GoogleCodeExporter]

Thx for the patch, but...
- torrent duplicate sould check by hash. (GetTorrentByName -> GetTorrentByHash)
- what happend, if user add a torrent by url? there was no metainfo data in 
request,  arguments[ProtocolConstants.FIELD_METAINFO] will be NULL

And this is a good fallback handling, for some situation. But we can save for a 
ride, if we check the duplicate at torrentadddialog. ("this torrent already 
exists, would you like to add the tracker to that torrent", and send the 
trackeraddrequrest)

Original comment by elso.and...@gmail.com on 1 Jul 2011 at 11:30

• Changed state: Accepted

[GoogleCodeExporter]

Thanks for the feedback Elso,
I agree about the GetTorrentByHash idea, I tried this initially but I dont 
think I was getting the same hash from MonoTorrent. I may have been using 
InfoHash will try agian with GetHashCode(). (looking at mono torrent, 
GetHashCode is probably the same as infohash). If there's a way to translate or 
match this to the Torrent.Hash let me know.
I'll revisit it in any case.

You mentioned "torrentadddialog" I couldn't find it in the code so perhaps you 
are suggesting we add a new dialog. Again I agree completely, I had debated 
wheather it should be a setting or a dialog. maybe a dialog, with a setting 
"AddTrackersWithoutAsking (bool)"?

- what happend, if user add a torrent by url? there was no metainfo data in 
request.
In this case will there be a url in the request/response?
we can load the torrent through MonoTorrent .Load(Uri url, string location).
Where should the .torrent file be stored locally? temp? or is there dir that's 
used for such things. I'll take a look.

Best regards,
Ray

Original comment by rayfitzh...@gmail.com on 4 Jul 2011 at 9:20

[GoogleCodeExporter]

Hi all,

Changes in V2,
1. Torrent duplicate chacks by hash.
2. Add trackers by torrent url support, (torrent file is downloaded to the 
users temp dir)
3. Dialog to confirm if user wants to add trackers, setting for always add 
(AddTrackersSilently) with check box on local setting form.
4. Edit Trackers context menu from Trackers Tab on bottom opens 
TorrentPropertiesDialog on trackers tab.

Best regards,
Ray

Original comment by rayfitzh...@gmail.com on 5 Jul 2011 at 4:45

Attachments:

• AddTrackersWhenTorrentAlreadyExistsV2.patch

[GoogleCodeExporter]

i'm running transmission-daemon 2.42 (13013). does this support the mentioned 
feature?

Original comment by petesimontabibito on 19 Feb 2012 at 10:14

[GoogleCodeExporter]

Yes please let us know if 2.42 support this because i cannot see it working.

Original comment by djpi...@gmail.com on 27 Feb 2012 at 2:47

[GoogleCodeExporter]

i have the same problem after 2.42 as well

Original comment by nahar...@gmail.com on 7 May 2012 at 1:03