apoelstra / secp256k1-zkp

Personal fork of -zkp. Has some old mimblewimble stuff but mostly I just PR everything upstream now.
MIT License
82 stars 27 forks source link

Minor error in bench_bulletproof.c #17

Open Henrikls opened 11 months ago

Henrikls commented 11 months ago

Hello, I was experimenting with the Bulletproof library and noticed a minor error in bench_bulletproof.c. This issue arises when installing the library with specific configuration modules. The mistake occurs on line 302 and is as follows:

data.generators = secp256k1_bulletproof_generators_create(data.ctx, &data.blind_gen, 64 * 1024, 1);

The correct code, as indicated by line 299, should be: data.generators = secp256k1_bulletproof_generators_create(data.ctx, &data.blind_gen, 64 * 1024);

It's only a minor mistake, but I thought it was worth pointing out. Other than that, everything works well. If you're interested in how I configured it, I've included a brief note below:

git clone -b bulletproofs https://github.com/apoelstra/secp256k1-zkp/

./autogen.sh

./configure --enable-module-commitment --enable-module-rangeproof --enable-module-generator --enable-module-bulletproof --enable-experimental

*Now to fix a minor error open the file located at: /secp256k1-zkp/src/bench_bulletproof.c and change line 302 to: data.generators = secp256k1_bulletproof_generators_create(data.ctx, &data.blind_gen, 64 1024);**

Now run: make ./tests sudo make install

To check if everything gets installed write the following: ls "/usr/local/include/"

The output should show something like the following: secp256k1_bulletproofs.h secp256k1_ecdh.h secp256k1_extrakeys.h secp256k1_preallocated.h secp256k1_schnorrsig.h secp256k1.h secp256k1_commitment.h secp256k1_ellswift.h secp256k1_generator.h secp256k1_rangeproof.h