apogiatzis
commented
4 years ago Hello Strato,
Thanks for your PR and contribution and apologies for the late response.
Although I haven't examined the PR thoroughly it looks really good to me!
Merging this now! Also, feel free to post this anywhere you like.
Lastly, I like the idea of co-authoring this with you if you are still interested!
Thanks again and keep safe as well!
Hi Andrea,
I'm not sure if you would like to merge this one.
It (greatly) enhances the functionality that you provide, by providing extra configuration parameters and enhancing the existing ones.
I'm scratching my own itch here, where I have multiple containers that need to be restarted automatically, and although your utility would perfectly deal with one container, it could not handle such a case.
I have tried and kept backwards compatibility with all previous configuration params, so this update should NOT be disruptive to existing users (for example I would have liked to rename the
RELOAD_DIRconfiguration parameter toRELOAD_DIRSto better reflect that this could be a list of directories, but I didn't). You can see the update Readme file on my forkExcuse my editor for applying a (much) different python source code formatting (based on black) but I think the changes are clear enough.
I also fixed your test case that did not seem to work correctly.
As I think this is an improvement on the original design (αν δεν παινέψεις το σπίτι σου...) if you choose to not merge this, I would like to have your permission to post this on my github account, obviously with credit to your original work. But I really do not think this needs to have a separate home. Maybe we could be co-authors on this one!
I really look forward to see this live soon, as I said I got to really use this!
Thanks! Stay safe!