search

apognu / otter

Music player for Funkwhale
MIT License
215 stars 21 forks source link

Future Changes in Funkwhale Authentication #122

Closed critbase closed 3 years ago

critbase commented 3 years ago

I recently started tracking upstream's develop branch in my funkwhale instance. Because of this, I noticed that there are breaking changes in authentication upstream; specifically, the removal of the /api/v1/token and /api/v1/token/refresh endpoints.

The relevant commits seem to be these: Remove JWT related code and Remove last JWT related includes.

This isn't a pressing issue yet; these commits are only in the develop branch, and aren't even present in any release. Still, I feel it's worth being aware of potential breaking changes.

georgkrause commented 3 years ago

This seems to be critical to be done when Funkwhale 1.2 is released. But some preparations are already done: https://github.com/apognu/otter/commit/002ebec7ce9bea61beb30f57a038e95fb65353ff

Etua commented 3 years ago

I think this issue is a duplicate of #63

critbase commented 3 years ago

ah, i missed that. closing in favor of #63