search

apognu / otter

Music player for Funkwhale
MIT License
216 stars 21 forks source link

Allow to filter own music #33

Closed georgkrause closed 4 years ago

georgkrause commented 4 years ago

When I open Otter, I get a hell of a lot of music which is federated from other pods. Some of them don't even have playable tracks. It would be nice if I could filter the results to show only my music.

apognu commented 4 years ago

Hi, thanks for reporting this.

How would you seen this control implemented? Could it be tucked under settings or does it need to be handy because you need to be able to switch it on and off often?

apognu commented 4 years ago

For reference, there seems to be a GET params, scope, that changes to display one's own music vs. other's music : scope=all and scope=me.

georgkrause commented 4 years ago

I'd prefer to have a filter option available in the library view instead of an setting somewhere behind menus. But I could live with this option, too, if its easier.

apognu commented 4 years ago

It's mostly a UX issue. I'd like not to overwhelm the UI with options. Maybe I can add it to the main bottom bar overflow menu: easily accessible, but out of the way.

georgkrause commented 4 years ago

unrelated comment, sorry

In case of the UI I would like to suggest a button next to the shuffle button in the album view: ![grafik](https://user-images.githubusercontent.com/939889/83790597-bb8c5f00-a698-11ea-8f18-68b9006dee53.png) Maybe simply another button for "Download". In my case I would most likely make only full albums available in the device, but I guess in the song context menu might also be a good place: ![grafik](https://user-images.githubusercontent.com/939889/83790714-e70f4980-a698-11ea-8a10-44b5181c929e.png)
apognu commented 4 years ago

@georgkrause Did you write that comment on the wrong issue? This seems related to #37.

georgkrause commented 4 years ago

Yes, sorry for this. I like your idea.

If you can point me somewhere I could try to implement it

apognu commented 4 years ago

This should be implemented in d92e73cdabaef18d42ddd71a8be820ab265515c1. I'll merge into develop when I have had the chance to test it a little. This requires Funkwhale 0.21+, since the scope parameter was added then, if I'm not mistaken.

This is how it looks like (easily available from every "browse" section).

georgkrause commented 4 years ago

Is there a way to get a apk of this version from CI for testing?

apognu commented 4 years ago

Not yet, but I should merge this branch tonight or tomorrow, and the build will then be available in the tip release.

I'll comment here when it is.

apognu commented 4 years ago

A debug build is now available here. The feature is not behind the experimental flag yet, and will stay that way unless we notice some blocking issues.

You can reopen this issue if you want to continue discussing this feature (enhancements or bugs).

The build also contains the first preview for #37 (Offline downloading of tracks), which still needs some work, but is functional.