search

apognu / otter

Music player for Funkwhale
MIT License
216 stars 21 forks source link

added support for german (de) #38

Closed arneschlag closed 4 years ago

arneschlag commented 4 years ago

Translated into German

apognu commented 4 years ago

Hi!

Thanks for this. Could you reproduce the same order and spacing as the original English and French translation files?

We will also need to determine what happens to any newly-introduced strings (there are already a few on master) . I will be quite unable to translate them into German myself, and Android forces me to have them. Should I keep English for those new strings until someone contribues a translation or use some auto-generated translation from Deepl, for example?

apognu commented 4 years ago

The deadline fot this to be included in 1.0.17 has passed, so it will be merged into 1.0.18 as soon as the requested fix is implemented and a strategy for future string adition adopted.

arneschlag commented 4 years ago

Hi!

Thanks for this. Could you reproduce the same order and spacing as the original English and French translation files?

I now adapted the spacing.

We will also need to determine what happens to any newly-introduced strings (there are already a few on master) . I will be quite unable to translate them into German myself, and Android forces me to have them. Should I keep English for those new strings until someone contribues a translation or use some auto-generated translation from Deepl, for example?

I can translate them into german, where can i find them?

apognu commented 4 years ago

Thanks for the edit!

The new strings are in the updated version of strings.xml you started from, mainly strings about radio support, by the end of the file.

You can also follow #41, which suggests using a tool to help centralize and manage translations.

apognu commented 4 years ago

I was mistaken about the requirements of having all strings translated for the project to compile. So I will merge this as soon as possible (it will be included in 1.0.18). If you have the chance to translate the missing strings in the meantime, that would be perfect.

arneschlag commented 4 years ago

I added the missing translations. what is about the item: manage_add_to_playlist, it seems not to be used? Also it seems, that this item is not translated correctly in english.

It seems to be an good idea, do use a tool to help centralizing and managing translations better.

apognu commented 4 years ago

Merged! Thanks for reporting the two issues. The first had just been fixed. The latter is now fixed!