apognu / otter

Music player for Funkwhale
MIT License
214 stars 21 forks source link

Queue icon rotates without queue change #84

Closed ellienieuwdorp closed 3 years ago

ellienieuwdorp commented 3 years ago

Been using Otter a lot lately and came across this small bug. If you enter the search screen or settings screen and exit back to MainActivity the queue icon always rotates like there's been a queue change. I think this happens because in onResume of MainActivity it sends the refresh event which sends the QueueChanged event, even though calling onResume() of MainActivity doesn't mean there's been a queue change.

I think this line should be removed. If you actually add a song to the queue in a search window the queue seems to function and display fine still even with this removed. https://github.com/apognu/otter/blob/300cc54e9733139489e69eb014fc1f17299adae9/app/src/main/java/com/github/apognu/otter/playback/PlayerService.kt#L148