search

apognu / tuigreet

Graphical console greeter for greetd
GNU General Public License v3.0
977 stars 45 forks source link

cpu usage is tenfold after commit fd86e67 Limit UI refresh frame rate #113

Closed ghost closed 1 year ago

ghost commented 1 year ago

The cpu usage is tenfold after commit fd86e67 Limit UI refresh frame rate. Before this commit the cpu usage for an idle tuigreet process was at about 0.65 percent. After this commit the cpu usage for an idle tuigreet process is at about 6.5 percent. I'm not sure if this is related, but the cursor in the password field blinks at very irregular intervals.

apognu commented 1 year ago

Thanks for reporting this, I'll have a look.

The cursor was already blinking inconsistently in previous versions for me and some reporters (which I attributed to crossterm but it may be that I did something wrong in that update.

Was the cursor okay for you before the update?

If you could also try with the commit before that one, to check if it is the issue, that would be great. Because we also updated the TUI library that we use a few commits before.

ghost commented 1 year ago

Thank you for looking into this. The cursor is about the same as before, so that is not related to this issue. I did find this crossterm issue: https://github.com/apognu/tuigreet/issues/71. Would using SetCursorStyle to disable blinking help? This was introduced in https://github.com/crossterm-rs/crossterm/pull/742/commits In case I can help testing please let me know.

apognu commented 1 year ago

I tried all those cursor style options, they are not being respected by the TTY unfortunately.

I'll see if I can reproduce the high CPU usage, though and report back.

apognu commented 1 year ago

The latest commit on master should hopefully revert the CPU usage regression (and maybe even improve it a bit). Could you verify that things are working properly and that you are not seeing the issue anymore?

ghost commented 1 year ago

Thank you very much for the update :-) The CPU usage is now at about 0.3 percent, so indeed even quite lower than originally. And the result, as in blinking, is a lot better. The attempts to disable blinking probably failed because this requires root privillege, or at least write acces to perform: echo 0 > /sys/class/graphics/fbcon/cursor_blink I'll try to find the correct kernel parameter for users who want to use that tomorrow, so this might be added to the README.md.