search

apognu / tuigreet

Graphical console greeter for greetd
GNU General Public License v3.0
925 stars 41 forks source link

Feature request: Allow multiple asterisks-chars #122

Closed Kaligule closed 5 months ago

Kaligule commented 8 months ago

Currently you can use --asterisks-char x to select a single "character to be used to redact secrets (default: *)".

I suggest allowing to use multiple characters here: --asterisks-char xyz. Then when the user types in his password, for each letter a random character from the list would be shown.

why?

This would allow the user to look cool when typing his password, because it looks like their password is ᐷᐐᐖᐚᐬᐰᐹ

is this feature creep?

Yes, sorry. I still think it would be cool, though.

apognu commented 5 months ago

This should be implemented. Could you try the main branch out and give feedback?

Kaligule commented 5 months ago

That looks so cool :) I won't be able to test main for a few weeks, but I looked at the code and it looks right. Well done and thank you.

apognu commented 5 months ago

Thanks! I'll close this until then, feel free to reopen if you notice something wrong. :)