search

apognu / tuigreet

Graphical console greeter for greetd
GNU General Public License v3.0
992 stars 45 forks source link

Only first component is colored according to theme spec #147

Closed krrogala closed 3 months ago

krrogala commented 5 months ago

Describe the bug I've used the sample theme spec in the README and made changes to it myself, but, no matter what I do, only the first component has its color changed and the rest is ignored

To Reproduce Steps to reproduce the behavior:

  1. Open /etc/greetd/config.toml
  2. Add command = "tuigreet --cmd Hyprland -i --theme greet=lightmagenta;prompt=blue"
  3. Comment out existing command

Expected behavior I expect that each component is colored according to the Theme spec I provide

System information:

Additional context When I added -d /tmp/tuigreet.log at the end of the command line, it did not log anything to that file. When I moved it in front of --theme then it worked.

Debug log Run tuigreet with the -d [FILE] option to log tracing information into the specified file, to append here. 2024-06-13T17:13:19.594247Z INFO tuigreet: 49: tuigreet started 2024-06-13T17:13:22.088736Z INFO tuigreet::ipc: 36: sending request to greetd: CreateSession { username: "user" } 2024-06-13T17:13:22.135724Z INFO tuigreet::ipc: 75: received greetd message: AuthMessage { auth_message_type: Secret, auth_message: "Password: " } 2024-06-13T17:13:26.995980Z INFO tuigreet::ipc: 36: sending request to greetd: PostAuthMessageResponse 2024-06-13T17:13:27.032009Z INFO tuigreet::ipc: 75: received greetd message: Success 2024-06-13T17:13:27.032021Z INFO tuigreet::ipc: 153: authentication successful, starting session 2024-06-13T17:13:27.032052Z INFO tuigreet::ipc: 36: sending request to greetd: StartSession { cmd: ["Hyprland"], env: [] } 2024-06-13T17:13:27.032409Z INFO tuigreet::ipc: 75: received greetd message: Success 2024-06-13T17:13:27.032414Z INFO tuigreet::ipc: 119: greetd acknowledged session start, exiting 2024-06-13T17:13:27.032508Z INFO tuigreet: 122: preparing exit with status Success 2024-06-13T17:13:27.036461Z INFO tuigreet: 90: exiting main loop

krrogala commented 5 months ago

I now see that I have to enclose the SPEC for the theme in single quotes to make it work. Not sure if this is intended, but I didn't pick it up in the Readme. Anyways, works great and thank you for putting together this greeter!

apognu commented 3 months ago

Yes, the semicolon is interpreted by your shell to separate commands, my guess is without the quotes, only the first command is executed by greetd. I will update the README to emphasize this.

Thank you for reporting.