apokalipto / devise_saml_authenticatable

Devise SAML 2.0 authentication strategy
MIT License
294 stars 153 forks source link

ruby-saml latest update -> idp_sso_target_url changed to idp_sso_service_url #192

Open rcamps opened 3 years ago

rcamps commented 3 years ago

Please see https://github.com/onelogin/ruby-saml#updating-from-111x-to-1120

The change to the relevant setting key names in ruby-saml's most recent update causes all devise SAML requests to fail.

adamstegman commented 3 years ago

Hi @rcamps, there shouldn't be anything in the gem that would be affected by this upgrade. Have you updated your SAML configuration that is passed to the gem?

You can see the changes I made in #192 to support ruby-saml 1.12 in our tests. No changes were made to the library code.