clear clock sticky bits in initial task

apollo-lhc / cm_mcu

Microcontroller source code for the APOLLO blade for the CMS tracker HL-LHC upgrade.

MIT License

2 stars 2 forks source link

clear clock sticky bits in initial task #186

Closed pkotamnives closed 1 year ago

pkotamnives commented 1 year ago

we remove clock_ctl but add clearclk_ctl for a CLI command %clearclk that can clear all clock sticky bits
clear_clk_stickybit() is called after a clock is programmed in init Task.
currently, a few registers with sticky bits are part of registers to monitor by %clkmon. However, not sure if we want to add more registers or remove some that are not necessary.

this PR will resolve issue #184

pwittich commented 1 year ago

btw I noticed that there is a lot of repeated code looking at this https://github.com/apollo-lhc/cm_mcu/blob/3a2a6a8696ed3972f3c37e14c7445ad0c42b8f94/projects/cm_mcu/AlarmUtilities.c#L213-L232 and this https://github.com/apollo-lhc/cm_mcu/blob/3a2a6a8696ed3972f3c37e14c7445ad0c42b8f94/projects/cm_mcu/AlarmUtilities.c#L241-L274

pkotamnives commented 1 year ago

btw I noticed that there is a lot of repeated code looking at this

https://github.com/apollo-lhc/cm_mcu/blob/3a2a6a8696ed3972f3c37e14c7445ad0c42b8f94/projects/cm_mcu/AlarmUtilities.c#L213-L232

and this

https://github.com/apollo-lhc/cm_mcu/blob/3a2a6a8696ed3972f3c37e14c7445ad0c42b8f94/projects/cm_mcu/AlarmUtilities.c#L241-L274

Sure, I can loop over GEN FPGA1 and FPGA2. Planning to do the same with getting FPGA's vendor parts in LocalTask.cc which is also pretty repetitive.

pwittich commented 1 year ago

Sure, I can loop over GEN FPGA1 and FPGA2. Planning to do the same with getting FPGA's vendor parts in LocalTask.cc which is also pretty repetitive.

ok up to you if you want to do this in this PR or in a new one