Send more data to Zynq - Githubissues

apollo-lhc / cm_mcu

Microcontroller source code for the APOLLO blade for the CMS tracker HL-LHC upgrade.

MIT License

3 stars 2 forks source link

Send more data to Zynq #191

Closed pkotamnives closed 10 months ago

pkotamnives commented 1 year ago

This PR will resolve a few ZynqMonPath tags in issues. More test and debugging are needed, but the infrastructure is in place.

The following data streams have been added only for REV2:

clk monitoring
if a 6bit-mask if any 12-ch FFs are 25Gbs ones
if a 20bit-mask if any FFs are present
optical receiver's power for all receivers/transceivers with 25Gbs

We also need to sync the data structure in this code with the one in zynqmon_2

pwittich commented 1 year ago

To shut up codacy maybe add a code check like

If ( i > SOME_MAX_VAL) return SOME_ERROR_CONDITION;

Where you have to figure out a sensible SOME_MAX_VAL and SOME_ERROR_CONDITION. In particular not obvious to me what the error condition should be. You have the configASSERT but that is not a standard C thing so I don't think codacy recognizes it.