apollo-lhc / cm_mcu

Microcontroller source code for the APOLLO blade for the CMS tracker HL-LHC upgrade.
MIT License
3 stars 2 forks source link

fix bug in the 2nd fpga i2c device response to ipmc #193

Closed pwittich closed 1 year ago

pkotamnives commented 1 year ago

@pwittich, I will merge it soon but could you enlighten me why is it 4 and not 1?

pwittich commented 1 year ago

good that you asked. I realize now I have to make it different for Rev1 and Rev 2.

There is one temperature entry per SLR in the FPGA.

Version F_1 F_2
Rev 1 KU15P - 1 SLR VU7P - 2 SLR
Rev 2 VU13P - 4 SLR VU13P - 4 SLR

So for the 2nd FPGA on Rev 1 there is one SLR before it so it is at index 1. In Rev 2 there are four, so it is index 4.

pkotamnives commented 1 year ago

I have not tried the ipmitool command but someone said they can read FPGA2's temperature now. So, I'll just merge it?