apollo-lhc / cm_mcu

Microcontroller source code for the APOLLO blade for the CMS tracker HL-LHC upgrade.
MIT License
3 stars 2 forks source link

Bug in firefly disable/enable laser #224

Closed pwittich closed 5 months ago

pwittich commented 5 months ago

https://github.com/apollo-lhc/cm_mcu/blob/094b3e24790fcca25c40d96a2ccac0d1dcd1387b/projects/cm_mcu/commands/SensorControl.c#L144

should be

value &= 0xF;
pwittich commented 5 months ago

Also affects disable_receivers here: https://github.com/apollo-lhc/cm_mcu/blob/094b3e24790fcca25c40d96a2ccac0d1dcd1387b/projects/cm_mcu/commands/SensorControl.c#L176 same fix/